Skip to content

fix: doc typo #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: doc typo #950

merged 1 commit into from
Apr 10, 2025

Conversation

@awfabian-rs
Copy link
Contributor

No description provided.

@awfabian-rs
Copy link
Contributor Author

awfabian-rs commented Apr 9, 2025 •
edited
Loading

Looks like a typo, verbal description doesn't match the diff. Also 'none' in the code: https://github.com/rackerlabs/genestack/blob/main/ansible/inventory/genestack/group_vars/k8s_cluster/k8s-cluster.yml#L70

Although cni is a valid option, the comment says:

 # Choose network plugin (cilium, calico, kube-ovn, weave, flannel or none. Use cni for generic cni plugin)
 # Can also be set to 'cloud', which lets the cloud provider setup appropriate routing

rackerchris
rackerchris approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@rackerchris rackerchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@rackerchris rackerchris merged commit 20f7461 into rackerlabs:main Apr 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rackerchris rackerchris rackerchris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@awfabian-rs @rackerchris