feat: update enroll and resource class assignment to new hardware categorization #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've moved to using flavor definitions that are defined in the deploy repo which are then applied on deployment rather than having a specific operator like this apply them.
Remove the resource class matching from the enroll code so that we can migrate to utilizing the inspection hooks directly.
This code is trying to use the standard library dataclasses, it should import that and not rely on a leaked export of the standard library data class.
cardoe
force-pushed
the
update-enroll
branch
6 times, most recently
from
6778022 to
ac761fe
Compare
Update the code and the tests to read data that conforms to the new schema.
Create an OpenStack automation account for enroll-server and update the secret references to this account. Drop all references to the old flavor data since this is not where it will be used. Added a call to 'inspect' during the enrollment process.
Added the resource class to be called by default in the agent inspector hooks. Switch to using agent inspection for now by default as well. Add a mount to include the data into the conductor.
Unfortunately the IPA image reports the number of CPU threads and not the number of CPU cores without giving us the ability to calculate the cores because there's no value to say that hyperthreading is enabled or not. The model of the CPU should be detailed enough for us to be happy that this is correct so we'll just drop CPU core count.
The manufacturer sometimes includes ' Inc.' and sometimes not, so let's just trim that to make things consistent.
cardoe
requested review from
a team,
RSabounds,
andrrax,
haseebsyed12,
mfencik,
nicholaskuechler,
skrobul and
stevekeay
haseebsyed12
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the hardware matcher code to load the new hardware categorization data format. Update the enroll-server code to not manipulate the resource class directly. Updated the ironic resource-class hook to use the new data and be called by default with agent inspection. Enabled agent inspection by default as well.