feat: add pyright type checking to workflows python code #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
stevekeay
changed the title
stevekeay
changed the title
stevekeay
force-pushed
the
ingest-server-pyright
branch
from
1466026 to
dfc0ffb
Compare
stevekeay
force-pushed
the
ingest-server-pyright
branch
5 times, most recently
from
7d9799e to
ada8e28
Compare
cardoe
reviewed
Nov 8, 2024
stevekeay
force-pushed
the
ingest-server-pyright
branch
4 times, most recently
from
53ac0f6 to
d66492c
Compare
stevekeay
changed the title
Note that we hard-code python deps because the pre-commit checker operates in its own independent venv and cannot access the deps that poetry installs. This seems broken, as it allows the versions to drift. However it is better than nothing.
cardoe
force-pushed
the
ingest-server-pyright
branch
from
d66492c to
1719ad5
Compare
cardoe
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two options - mypy or pyright. This PR explores the pyright option. #424 explored the other