feat: "router trunks" #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfencik
force-pushed
the
router_trunk
branch
13 times, most recently
from
8e12d2d to
827b375
Compare
skrobul
force-pushed
the
router_trunk
branch
17 times, most recently
from
1eed3c9 to
b159b61
Compare
In some situations we may end up on a leaf where the dynamic segment for that particular vlan group already exists. In such cases, we should reuse this rather than attempting to allocate another segmentation_id.
We want to allow using local segmentation_id on the trunk ports facing network nodes.
We have addeed subports_added_post handler that is triggered after the validation of data is completed and the record is committed to the neutron's database to make sure that all of the segments can be looked up by undersync. Now the original trigger of undersync is no longer needed.
This reverts commit 45afe61. No longer needed because we are using ML2 OVN client
Prior to this commit we have leveraged the OVN ML2's plugin helper method of create_provnet_port which correctly creates the port, but unfortunately that port gets removed every time the Neutron restarts. This is because the Neutron OVN plugin performs a database sync and when it iterates over the LSPs that are prefixed with `provnet-` it checks if there is a corresponding Neutron Port that is attached to the provider network. In our case, such port does not exist so the OVN localnet port gets removed breaking the connectivity. Instead of relying on the helper, we execute very similar code but prefix our LSP with `uplink-` to make it excluded from the Neutron/OVN sync cleanup.
tests are still broken, so this commit is a wip
nicholaskuechler
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.