gtk: round down scaled arguments to make-GdkRectangle #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capfredf
force-pushed
the
fix-bug
branch
2 times, most recently
from
ec6a0b2 to
df900fc
Compare
Member
Author
|
@samth can you take a look? |
Member
|
Should this use |
Member
|
I'm ok with merging this; I don't know if @mflatt has any thoughts. |
Member
|
LGTM |
Member
|
@mflatt when I looked at the docs it wasn't clear to me what the behavior of _int and similar was on integers that are not exact. Is that intended to be in the domain? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #280 and fixes the ci issue