Parametric surface3d #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and polygons) 3d renderers
Member
|
this is so awesome I'm begging for this PR to be merged. Kind regards, Stephen |
|
I just tested this. It looks excellent. Good work and thank you! |
Member
|
thanks @bdeket ! |
Member
|
@jeapostrophe and thank you Jay for responding so quickly! |
alex-hhh
added a commit
to alex-hhh/plot
that referenced
this pull request
Jul 16, 2020
This commit introduces the a new way of writing plot tests where a sample plot is recorded and compared against the current rendering of the plot. These types of tests have the ability to automatically detect changes in the way the plots are rendered. This commit only adds tests for changes in racket#5 and racket#59, since these were recently merged and had no tests, as well as racket#55 since this pull request used 3D plots, and I wanted to validate the method for 3D plots as well. Instead of comparing bitmap or vector images, plots are rendered using `plot/dc` or `plot3d/dc` to a special `record-dc%` object and the draw steps are written to a file. When running the tests, the new set of draw steps are generated and compared to the saved ones. The `record-dc%` used for drawing is updated to report consistent values for text dimensions, regardless of the font -- this allows the data files to be used across different platforms which would generate slightly different plot images due to different fonts being available. In addition to this, a sample PNG image is saved for each plot -- this allows the user to manually run the tests and having something to compare the result. The verification steps are automated in `check-draw-steps` and `check-draw-steps3d` such that, when a verification fails, a new set of draw steps are written to file, as well as a new sample image. The GitHub Actions `ci.yml` has been updated to upload these files as an artifact, so we have the data to analyze failed runs on GitHub Actions. The test will work fine without this feature, so they can be run on DrDr or the users computer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 3d renderer for paramteric surfaces
this is faster than the trick used for polar3d, where an isosurface is used, since the right values for the polygons can be directly computed
also exposes a renderer for polygons, similar to lines3d