Setup CI for the plot package #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... modeled after the racket/web-server ci.yml
samth
approved these changes
Jun 30, 2020
.github/workflows/ci.yml
Outdated
| racket-variant: ["regular"] | ||
| steps: | ||
| - uses: actions/checkout@master | ||
| - uses: Bogdanp/setup-racket@v0.3 |
Member
There was a problem hiding this comment.
I recommend using the latest version, which is 0.8 right now.
| - run: raco pkg config --set catalogs `cat catalogs.txt` | ||
| - run: raco pkg config catalogs | ||
| - run: sudo raco pkg install --batch --auto plot | ||
| # - run: raco test --drdr plot-test/ |
Member
There was a problem hiding this comment.
You might need xvfb here; see the use at https://github.com/racket/typed-racket/blob/master/.github/workflows/ci.yml#L29
.github/workflows/ci.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| racket-version: ["7.7"] |
Member
There was a problem hiding this comment.
Probably good to test snapshots as well.
Collaborator
Author
There was a problem hiding this comment.
I added the "current" as well as CS variants for Racket to the built, although, I am not convinced of their value to the build of plot -- "current" will be tested once the changes are merged to master anyway. OTOH, we don't pay for the build VM time...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up a CI build for the plot package, scheduled to run for pushes and pull requests. Currently it only runs for Racket version 7.7 and it does not run the tests. Tests need are currently run manually and their output visually inspected.
It is inspired by the web-server CI build, but uses a different strategy for the build:
NOTE: there are several commits in this branch, as I was experimenting with different approaches, but I will squash the commits when merged to the master branch, so only one commit shows up.