Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Conversation

pratikmallya
Copy link
Contributor

Some of the interfaces don't correspond well to the values
expected by the requests and returned by api.

depends on: #478
corresponds to: rackspace/rack#324

@pratikmallya pratikmallya changed the title Fix api interfaces for orchestration resources [rfr]Fix api interfaces for orchestration resources Sep 14, 2015
@pratikmallya pratikmallya force-pushed the fix_api_orchestration_interface branch from bc9ab61 to 80e4aad Compare September 14, 2015 15:39
@pratikmallya pratikmallya changed the title [rfr]Fix api interfaces for orchestration resources [wip]Fix api interfaces for orchestration resources Sep 14, 2015
@pratikmallya pratikmallya force-pushed the fix_api_orchestration_interface branch 2 times, most recently from 669b0fb to 3eafeb6 Compare September 14, 2015 16:13
@pratikmallya pratikmallya changed the title [wip]Fix api interfaces for orchestration resources [rfr]Fix api interfaces for orchestration resources Sep 14, 2015
@pratikmallya pratikmallya changed the title [rfr]Fix api interfaces for orchestration resources [wip]Fix api interfaces for orchestration resources Sep 14, 2015
@pratikmallya pratikmallya force-pushed the fix_api_orchestration_interface branch 3 times, most recently from dd4b232 to 574be7d Compare September 14, 2015 16:42
@pratikmallya pratikmallya changed the title [wip]Fix api interfaces for orchestration resources [rfr]Fix api interfaces for orchestration resources Sep 14, 2015
@pratikmallya pratikmallya force-pushed the fix_api_orchestration_interface branch from 574be7d to 33f0851 Compare September 14, 2015 16:49
@jrperritt
Copy link
Contributor

@pratikmallya Because of the built-in way Go handles package management (via go get), it's important that we are aware of backwards-incompatible changes that aren't bugs. For example, the issue of having the wrong time format I'd consider a bug, because users could not have gotten that working with their own code. Also, adding fields and functions/methods is also fine. However, changing types and removing fields is a bit more sensitive. For each of the changes in this PR where you changed a data type or removed fields, can you provide an explanation for why? When the orchestration service was implemented, it was coded against the docs here and here and tested against devstack and Rackspace public endpoints. I know the documentation may not reflect reality, but, if not, we need to know that.

@pratikmallya
Copy link
Contributor Author

@jrperritt good point. I will add comments to clarify why I made the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should have been in #466. Apologies

@pratikmallya
Copy link
Contributor Author

@jrperritt I added comments to the code where I changed the interface significantly. Let me know if you need more context.

@pratikmallya
Copy link
Contributor Author

@jrperritt can you please take a look?

@pratikmallya pratikmallya force-pushed the fix_api_orchestration_interface branch 2 times, most recently from a8c7a5c to 3c3f1fa Compare September 17, 2015 05:18
Some of the interfaces don't correspond well to the values
expected by the requests and returned by api.
@pratikmallya pratikmallya force-pushed the fix_api_orchestration_interface branch from 3c3f1fa to 827c03e Compare September 17, 2015 07:50
@pratikmallya
Copy link
Contributor Author

Closing, since commit is included in #486

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants