-
Notifications
You must be signed in to change notification settings - Fork 180
[rfr]Fix api interfaces for orchestration resources #483
[rfr]Fix api interfaces for orchestration resources #483
Conversation
bc9ab61
to
80e4aad
Compare
669b0fb
to
3eafeb6
Compare
dd4b232
to
574be7d
Compare
574be7d
to
33f0851
Compare
@pratikmallya Because of the built-in way Go handles package management (via |
@jrperritt good point. I will add comments to clarify why I made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should have been in #466. Apologies
@jrperritt I added comments to the code where I changed the interface significantly. Let me know if you need more context. |
@jrperritt can you please take a look? |
a8c7a5c
to
3c3f1fa
Compare
Some of the interfaces don't correspond well to the values expected by the requests and returned by api.
3c3f1fa
to
827c03e
Compare
Closing, since commit is included in #486 |
Some of the interfaces don't correspond well to the values
expected by the requests and returned by api.
depends on: #478
corresponds to: rackspace/rack#324