This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Add PrettyPrintJSON method for gophercloud.Link structure #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper method is useful when the contents need to be displayed.
There was a problem hiding this comment.
What is the use-case for this? The gophercloud.Links should be formatted if they are in the result and gophercloud.Result.PrettyPrintJSON is called. When would you need to format the links separately?
There was a problem hiding this comment.
@jrperritt that will format the entire result as JSON; but there are cases where we don't want all the result as JSON, only the links. e.g. https://github.com/rackspace/rack/pull/346/files#diff-89ed2b55dee1ba0cb9742aba85a8f6deR58
|
After discussing further, I agree we do not need this method |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper method is useful when the contents need to be
displayed.