Make the "change" parameter optional for add_policy and update_policy methods #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't accidentally replace a changePercent with a change - honor desired_capacity.
tests/unit/test_autoscale.py
Outdated
There was a problem hiding this comment.
I didn't mean to use ascii_only= on all these -- I temporarily used it to make it easier to read my error messages. I'll change it back.
EdLeafe
added a commit
that referenced
this pull request
Oct 3, 2013
Make the "change" parameter optional for add_policy and update_policy methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs this should fix:
#209 - policy.update(...) breaks with changePercent-based policies
#207 - really make it possible to use desiredCapacity now. the previous branch didn't work because change was still required, which conflicts.
I somewhat significantly refactored the implementation of update_policy, since the boolean logic needed to be a bit more strict about when it would use data from the policy and when it would use data passed in. I wrote several unit tests for the behavior of updating policies between different types of change (change, changePercent, and desiredCapacity), as well as tests for maintaining that state when the update_policy call wasn't explicitly passed any change-related parameters.
In addition to the unit tests I've done some ad-hoc tests against the production Auto Scale service.