Skip to content

Conversation

@jaraco
Copy link
Contributor

@jaraco jaraco commented Oct 5, 2014

I believe this approach is sound. It will raise a StopIteration instead of a KeyError if keys() is empty, but I suspect the actual exception in that case is not important. If it's important to keep that behavior, an alternative approach would be to cast the result of keys() to a list before dereferencing the first element.

@sivel
Copy link
Contributor

sivel commented Oct 6, 2014

Currently Python 3 is not supported by pyrax. While this is important and a goal for the project, python 3 compatibility will need to be solved at a larger scale. At the moment there are 711 errors and 7 failures running the unit tests against python 3.4 which amounts to about 57% test failure.

The current version of python supported with pyrax is python 2.7.

For the time being I am going to close this issue.

@sivel sivel closed this Oct 6, 2014
@jaraco
Copy link
Contributor Author

jaraco commented Oct 7, 2014

Oh?! :(

I'm not sure I understand. I've already submitted some broad patches to support Python 3. Thanks in part to those fixes, I was able to use import_domain under Python 3.

This fix addresses a specific bug which I tracked to its source, documented with a ticket, and fixed in a surgical, compatible way.

I've followed the style guidelines. I've committed to the proper branch. The tests all pass. I've made this PR imminently pullable.

I understand that Python 3 is not supported. How do you intend to support it without fixing the issues? What would it take to accept this PR?

@jaraco
Copy link
Contributor Author

jaraco commented Oct 9, 2014

In #481, you mentioned a desire to be strict on exceptions. I'll update the PR to take that approach.

@jaraco
Copy link
Contributor Author

jaraco commented Oct 9, 2014

It seems I'm unable to amend the pull request now that it's closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants