[fixed #1441] isActive false positive when URL not finished #1651
+19
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a huge bug for the isActive. If I had a path starting with /hell and another by /hello, isActive would think /hello is active when I am on the /hell URL. This is perfectly fixed now :)
I wasn't able to write unit tests because
karma start
was crashing for me. I would get this:(Looks like Travis was having the same error before my PR)