Skip to content

Feature specs: Applications.Core/secretStores extended use cases #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 6, 2025
Merged

Feature specs: Applications.Core/secretStores extended use cases #57

merged 25 commits into from
Mar 6, 2025

Conversation

@willtsai
Copy link
Contributor

@willtsai willtsai commented Jul 26, 2024

Here are the feature specs for extending the use cases of Applications.Core/secretStores

willtsai added 3 commits July 26, 2024 16:01
@willtsai
add secret store scenario extension feature specs
d758e9f 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
spelling corrections
1338afe 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
spelling corrections
c0ebedb 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
rynowak
rynowak reviewed Jul 29, 2024
View reviewed changes
rynowak
rynowak reviewed Jul 29, 2024
View reviewed changes
superbeeny
superbeeny reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@superbeeny superbeeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have the one question around naming conventions for types.

@willtsai
Merge branch 'main' into secret-store-scenarios
dfda0b0 
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
rynowak
rynowak reviewed Aug 1, 2024
View reviewed changes
rynowak
rynowak reviewed Aug 1, 2024
View reviewed changes
rynowak
rynowak reviewed Aug 1, 2024
View reviewed changes
willtsai added 3 commits August 1, 2024 15:39
@willtsai
add content
443523e 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
add content
6131515 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
address feedback on proposed examples
38a8ee3 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 20, 2024

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 20, 2024
@github-actions
Copy link

github-actions bot commented Aug 27, 2024

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

@github-actions github-actions bot closed this Aug 27, 2024
@willtsai willtsai reopened this Sep 16, 2024
kachawla
kachawla reviewed Sep 16, 2024
View reviewed changes
kachawla
kachawla reviewed Sep 16, 2024
View reviewed changes
kachawla
kachawla reviewed Sep 16, 2024
View reviewed changes
brooke-hamilton
brooke-hamilton reviewed Sep 16, 2024
View reviewed changes
kachawla
kachawla reviewed Sep 16, 2024
View reviewed changes
kachawla
kachawla reviewed Sep 16, 2024
View reviewed changes
lakshmimsft
lakshmimsft reviewed Sep 16, 2024
View reviewed changes
@github-actions github-actions bot removed the Stale label Sep 17, 2024
@brooke-hamilton brooke-hamilton mentioned this pull request Sep 24, 2024
Closed
4 tasks
@github-actions
Copy link

github-actions bot commented Oct 1, 2024

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 1, 2024
@github-actions
Copy link

github-actions bot commented Oct 9, 2024

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

@github-actions github-actions bot added the Stale label Jan 1, 2025
@github-actions
Copy link

github-actions bot commented Jan 9, 2025

This pull request has been closed due to inactivity. Feel free to reopen if you are still working on it.

@github-actions github-actions bot closed this Jan 9, 2025
@willtsai willtsai reopened this Jan 16, 2025
@github-actions github-actions bot removed the Stale label Jan 17, 2025
@willtsai
address review feedback
247b915 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
Merge branch 'main' into secret-store-scenarios
41572d4 
Signed-off-by: Will <28876888+willtsai@users.noreply.github.com>
@willtsai
address review feedback
bfaa9ce 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
Merge branch 'secret-store-scenarios' of https://github.com/willtsai/…
d69fc19 
…design-notes-radius into secret-store-scenarios
@willtsai
spellcheck fixes
0168874 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
spellcheck fixes
ded7018 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
ytimocin
ytimocin reviewed Jan 21, 2025
View reviewed changes
nithyatsu
nithyatsu reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@nithyatsu nithyatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I missed the conversation earlier, but with this feature, would there be changes to Credentials type that we use today for storing AZ and AWS secrets? If so, Then does secret store have to move into UCP's resource type?

sylvainsf
sylvainsf reviewed Jan 21, 2025
View reviewed changes
@willtsai
address feedback from Jan 21
3be6c66 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
address feedback from Jan 21
3237400 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
Copy link
Contributor Author

willtsai commented Jan 24, 2025

not sure if I missed the conversation earlier, but with this feature, would there be changes to Credentials type that we use today for storing AZ and AWS secrets? If so, Then does secret store have to move into UCP's resource type?

This feature spec should not affect how we store AZ and AWS secrets, thanks for checking though!

@willtsai
add dapr and udt use cases
85a24ff 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
add dapr and udt use cases
799c6c2 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Feb 8, 2025

This pull request is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 8, 2025
@willtsai willtsai removed the Stale label Feb 10, 2025
@willtsai
Copy link
Contributor Author

willtsai commented Feb 13, 2025

still waiting on another round of reviews

kachawla
kachawla reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates - looks great! Left a few clarifying comments.

willtsai added 2 commits March 5, 2025 20:38
@willtsai
address feedback from 20250305
65fc0c4 
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
@willtsai
Merge branch 'main' into secret-store-scenarios
320a690
@willtsai willtsai merged commit 7e1d737 into radius-project:main Mar 6, 2025
2 checks passed
@willtsai willtsai deleted the secret-store-scenarios branch March 6, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvainsf sylvainsf sylvainsf left review comments

@ytimocin ytimocin ytimocin left review comments

@lakshmimsft lakshmimsft lakshmimsft left review comments

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

@kachawla kachawla kachawla approved these changes

+3 more reviewers

@rynowak rynowak rynowak left review comments

@superbeeny superbeeny superbeeny left review comments

@nithyatsu nithyatsu nithyatsu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@willtsai @kachawla @sylvainsf @rynowak @superbeeny @ytimocin @brooke-hamilton @nithyatsu @lakshmimsft