Skip to content

Conversation

@lakshmimsft
Copy link
Contributor

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add envSecrets block to HowTo Custom Provider tutorial

willtsai
willtsai previously approved these changes Jul 26, 2024
Copy link
Contributor

@willtsai willtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition, just one minor suggestion for clarity

@willtsai willtsai self-requested a review July 26, 2024 22:15
@willtsai willtsai dismissed their stale review July 26, 2024 22:16

one more question about pgsSecretStore

@lakshmimsft lakshmimsft marked this pull request as ready for review July 26, 2024 22:27
@lakshmimsft lakshmimsft requested review from a team as code owners July 26, 2024 22:27
@willtsai willtsai merged commit f0b840f into radius-project:v0.36 Jul 26, 2024
sk593 pushed a commit that referenced this pull request Aug 7, 2024
* adding envSecrets

* updated per suggestion
sk593 pushed a commit that referenced this pull request Aug 7, 2024
* adding envSecrets

* updated per suggestion

Signed-off-by: sk593 <shruthikumar@microsoft.com>
sk593 added a commit that referenced this pull request Aug 13, 2024
* Update docs for v0.36.0

Signed-off-by: sk593 <shruthikumar@microsoft.com>

* Update auto-generated documentation (#1151)

* Autogenerate reference docs

Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>

* Update en-custom.txt

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>

* Add HowTo tutorial to configure Terraform Custom Provider (#1162)

* add howto doc for tf custom provider config

* unsaved files

* update per comments

* update for conflicts

* extra space

* extra space

* further comments

* capitalizing Environment

* one more change

---------

Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>

* correct highlight (#1164)

Signed-off-by: sk593 <shruthikumar@microsoft.com>

* Update index.md (#1160)

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>

* Add envSecrets block to HowTo Custom Provider tutorial (#1166)

* adding envSecrets

* updated per suggestion

Signed-off-by: sk593 <shruthikumar@microsoft.com>

* removing port input in config (#1167)

Signed-off-by: sk593 <shruthikumar@microsoft.com>

* revert

Signed-off-by: sk593 <shruthikumar@microsoft.com>

* fix spellcheck

Signed-off-by: sk593 <shruthikumar@microsoft.com>

* Update docs/layouts/partials/hooks/body-end.html

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: sk593 <shruthikumar@microsoft.com>
Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: rad-ci-bot <103787451+rad-ci-bot@users.noreply.github.com>
Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Reshrahim added a commit that referenced this pull request Aug 16, 2024
* Update docs for v0.36.0

* Update auto-generated documentation (#1151)

* Autogenerate reference docs

Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>

* Update en-custom.txt 

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

---------

Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Add HowTo tutorial to configure Terraform Custom Provider (#1162)

* add howto doc for tf custom provider config

* unsaved files

* update per comments

* update for conflicts

* extra space

* extra space

* further comments

* capitalizing Environment

* one more change

---------

Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>

* correct highlight (#1164)

* Update index.md (#1160)

Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>

* Add envSecrets block to HowTo Custom Provider tutorial (#1166)

* adding envSecrets

* updated per suggestion

* removing port input in config (#1167)

* Fix upmerge workflow error when no changes (#1192)

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>

* addressing comments

Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com>

* addressing comments

Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com>

---------

Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>
Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com>
Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com>
Co-authored-by: rad-ci-bot <103787451+rad-ci-bot@users.noreply.github.com>
Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com>
Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com>
Co-authored-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants