Skip to content

Conversation

@andy-hook
Copy link
Contributor

I noticed our SSR testing app was a little outdated while using it to test some changes.

This PR simply updates some outdated primitive apis and adds the slider to the ssr-testing app.

Copy link
Contributor

@benoitgrelard benoitgrelard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on this! Just a tiny nit.

@benoitgrelard
Copy link
Contributor

@andy-hook flaky tests again?

@andy-hook
Copy link
Contributor Author

@andy-hook flaky tests again?

Yep, kinda happy to see it fail as had a few others recently too. Been investigating and think I have a lead.

@andy-hook andy-hook merged commit 2070146 into main Jul 27, 2021
@andy-hook andy-hook deleted the update-ssr-testbed branch July 27, 2021 13:00
@andy-hook andy-hook changed the title Update SSR testbed Update SSR testing app Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants