Remove custom css webpack loader rules #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpacker 6 will provide loader rules by default when css webpack dependencies are detected. The custom loader rules were not set up correctly to work with the rest of the webpack config. Fixes @rails/webpacker issue #2916
Owner
|
Hey @rossta thanks for your reply - I've tested your solution and it did the trick ;). Thanks. Hovever after using recent libs (webpacker / webpack ) webpack-dev-server doesnt work properly - I mean despite webpack compiles js and css - I dont see any alert on site, even I had to set port to 3035 because it started by default on 8080, also hot reload doesnt work - after changing any js / css files - have to refresh site manually. Here are my changes: #4 - can you check it? |
Contributor
Author
|
See #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpacker 6 will provide loader rules by default when css webpack
dependencies are detected. The custom loader rules were not set up
correctly to work with the rest of the webpack config.
Fixes rails/webpacker#2916 and makes your demo app CSS work
with Webpacker 6.