-
-
Notifications
You must be signed in to change notification settings - Fork 83
fix(cli): force HTTP protocol for SuperTokens connection URI #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates the install command to rewrite SUPERTOKENS_CONNECTION_URI by replacing "https" with "http". Bumps CLI version from 0.1.8 to 0.1.9 in pyproject. Performs a minor whitespace cleanup in docker-compose.yml. No other logic, dependency, or structural changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai: add description and update title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cli/app/commands/install/run.py (1)
464-464: Refactor SUPERTOKENS_CONNECTION_URI to avoid brittle string replace
- Define a dedicated
connection_protocol = "http"and use it to build the URI instead of.replace("https", "http").- Add a comment explaining that SuperTokens Core listens over HTTP in the local Docker setup and that HTTPS must be configured explicitly for production overrides.
[cli/app/commands/install/run.py:464]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
cli/app/commands/install/run.py(1 hunks)cli/pyproject.toml(1 hunks)docker-compose.yml(1 hunks)
🔇 Additional comments (2)
docker-compose.yml (1)
55-55: LGTM! Formatting cleanup.The trailing whitespace removal is a good housekeeping change with no functional impact.
cli/pyproject.toml (1)
3-3: LGTM! Standard version bump.The version increment from 0.1.8 to 0.1.9 appropriately reflects the changes in this PR.
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 3893 🏁 Script executed: Length of output: 118 @zhravan: I've updated the PR title and description for you! ✨ Updated title: Description highlights:
The PR now has a descriptive conventional commit-style title and a complete description that explains what was fixed and why. You can view the changes here. 🐰 |
Issue
Link to related issue(s):
N/A - Internal bug fix
Description
Fixed the CLI installation configuration to use HTTP protocol for the SuperTokens authentication service connection instead of HTTPS. This resolves connection issues during installation where the SuperTokens service expects HTTP protocol.
Changes:
SUPERTOKENS_CONNECTION_URIto force HTTP protocol by replacing any HTTPS referencesScope of Change
Select all applicable areas impacted by this PR:
Screenshot / Video / GIF (if applicable)
N/A - Backend configuration change
Related PRs (if any)
None
Additional Notes for Reviewers (optional)
This fix ensures that the SuperTokens authentication service connection uses the correct HTTP protocol during CLI installation, preventing connection failures in default setups.
Developer Checklist
To be completed by the developer who raised the PR.
Reviewer Checklist
To be completed by the reviewer before merge.
Summary by CodeRabbit
Bug Fixes
Chores
Style