-
-
Notifications
You must be signed in to change notification settings - Fork 83
fix: feature flag ui and feature flag writes missing RBAC permissions #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds feature flag RBAC permissions in backend roles. Updates Feature Flags settings UI with search, enabled/disabled filters, grouped rendering with icons, loading skeleton, badges, and no-results messaging. Integrates RBAC guard on toggles. Expands i18n locales (EN/ES/FR/KN/ML) with new strings for common enabled/disabled and feature flag UI texts. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant UI as FeatureFlagsSettings (UI)
participant RBAC as RBACGuard
participant API as FeatureFlags API
U->>UI: Open Feature Flags tab
UI->>API: GET feature flags
API-->>UI: Flags list
UI->>UI: Apply search/filter (client-side)
alt No matches
UI-->>U: Show "no results" message
else Matches
UI-->>U: Render grouped flags with badges
end
U->>UI: Toggle a feature
UI->>RBAC: Check "feature_flags:update"
alt Permission granted
UI->>API: PATCH update feature flag
API-->>UI: Success/Failure
UI-->>U: Toast success or error
else Permission denied
RBAC-->>U: Action blocked
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (7)
🧰 Additional context used🧬 Code graph analysis (1)view/app/settings/general/components/FeatureFlagsSettings.tsx (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue
Link to related issue(s):
Description
Short summary of what this PR changes or introduces.
Scope of Change
Select all applicable areas impacted by this PR:
Screenshot / Video / GIF (if applicable)
Attach or embed screenshots, screen recordings, or GIFs demonstrating the feature or fix.
Related PRs (if any)
Link any related or dependent PRs across repos.
Additional Notes for Reviewers (optional)
Anything reviewers should know before testing or merging (e.g., environment variables, setup steps).
Developer Checklist
To be completed by the developer who raised the PR.
Reviewer Checklist
To be completed by the reviewer before merge.
Summary by CodeRabbit
New Features
Access Control
Internationalization