Fail-safe cleanup command

[kminek]

First of all thanks for great library!

I think cleanup command could be improved a little to be more fail-safe.

Those disk operations can throw exceptions:

https://github.com/rahulhaque/laravel-filepond/blob/12.x/src/Console/FilepondClear.php#L66
https://github.com/rahulhaque/laravel-filepond/blob/12.x/src/Console/FilepondClear.php#L67

This results in dead-loop because script exists at first error and no more records are cleared.

[rahulhaque]

Hi @kminek, you're welcome.

While my clear intention is to throw errors if file deletion fails, I'll recheck the possibilities of surpassing them.

[kminek]

maybe its my specific configuration but you can configure laravel disk to throw exceptions on failed operations, i am using this setup. i noticed something is wrong once cleanup command started failing on every run. i think i also noticed some invalid chunk exception earlier and the job was trying to delete following record:

i think i hit some edge case for sure

[rahulhaque]

What is the exception it throwing while failing to delete files or directories? Is it permission issue or file missing or anything else? The screenshot scenario is a valid one. If you could reproduce the delete exception and share the details, it would be lot easier for me to come up with a solution.

[kminek]

wait this is valid scenario? it throws:

League\Flysystem\UnableToDeleteFile
Unable to delete file located at: /app/app.server/storage/app/tmp/.

if path is empty string (as in my screenshot) it executes Storage::disk($tempDisk)->delete(''); and this exception is thrown.

[rahulhaque]

wait this is valid scenario?

Yes. It is a valid scenario when a chunk upload request is made but no chunk is uploaded yet. The package creates a directory for the chunks and database state is like the screenshot you have shared. During cleaning, the package first tries to delete the file and then the directory. As by default delete() method returns boolean, it doesn't throw exceptions.

Thanks for the exception message. I now know where to look at. I'll try running the tests with storage throw exception enabled. Let's see what changes I come up with.

[rahulhaque]

@kminek solved in version 12.3.5. Thanks for the report.