Updates for bulk insert/upsert (#795)

Typo

Author: aidanharan

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -137,6 +137,17 @@ def default_insert_value(column)
         end
         private :default_insert_value
 
+        def build_insert_sql(insert) # :nodoc:
+          sql = +"INSERT #{insert.into}"
+
+          if returning = insert.send(:insert_all).returning
+            sql << " OUTPUT " << returning.map {|column| "INSERTED.#{quote_column_name(column)}" }.join(", ")
+          end
+
+          sql << " #{insert.values_list}"
+          sql
+        end
+
         # === SQLServer Specific ======================================== #
 
         def execute_procedure(proc_name, *variables)
@@ -243,10 +254,12 @@ def sql_for_insert(sql, pk, binds)
             table_name = query_requires_identity_insert?(sql)
             pk = primary_key(table_name)
           end
+
           sql = if pk && use_output_inserted? && !database_prefix_remote_server?
                   quoted_pk = SQLServer::Utils.extract_identifiers(pk).quoted
                   table_name ||= get_table_name(sql)
                   exclude_output_inserted = exclude_output_inserted_table_name?(table_name, sql)
+
                   if exclude_output_inserted
                     id_sql_type = exclude_output_inserted.is_a?(TrueClass) ? 'bigint' : exclude_output_inserted
                     <<~SQL.squish

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -159,6 +159,22 @@ def supports_in_memory_oltp?
         @version_year >= 2014
       end
 
+      def supports_insert_returning?
+        true
+      end
+
+      def supports_insert_on_duplicate_skip?
+        false
+      end
+
+      def supports_insert_on_duplicate_update?
+        false
+      end
+
+      def supports_insert_conflict_target?
+        false
+      end
+
       def disable_referential_integrity
         tables = tables_with_referential_integrity
         tables.each { |t| do_execute "ALTER TABLE #{quote_table_name(t)} NOCHECK CONSTRAINT ALL" }

test/cases/coerced_tests.rb

@@ -1407,3 +1407,39 @@ class EnumTest < ActiveRecord::TestCase
     Book.connection.add_index(:books, [:author_id, :name], unique: true)
   end
 end
+
+
+
+
+require 'models/task'
+class QueryCacheExpiryTest < ActiveRecord::TestCase
+
+  # SQL Server does not support skipping or upserting duplicates.
+  coerce_tests! :test_insert_all
+  def test_insert_all_coerced
+    assert_raises(ArgumentError, /does not support skipping duplicates/) do
+      Task.cache { Task.insert({ starting: Time.now }) }
+    end
+
+    assert_called(ActiveRecord::Base.connection, :clear_query_cache, times: 2) do
+      Task.cache { Task.insert_all!([{ starting: Time.now }]) }
+    end
+
+    assert_called(ActiveRecord::Base.connection, :clear_query_cache, times: 2) do
+      Task.cache { Task.insert!({ starting: Time.now }) }
+    end
+
+    assert_called(ActiveRecord::Base.connection, :clear_query_cache, times: 2) do
+      Task.cache { Task.insert_all!([{ starting: Time.now }]) }
+    end
+
+    assert_raises(ArgumentError, /does not support upsert/) do
+      Task.cache { Task.upsert({ starting: Time.now }) }
+    end
+
+    assert_raises(ArgumentError, /does not support upsert/) do
+      Task.cache { Task.upsert_all([{ starting: Time.now }]) }
+    end
+  end
+
+end