Merge pull request #776 from aidanharan/unique-index-fixes

Rails 6: Fix tests that fail because of unique NULL indexes

Author: wpolicarpo

test/cases/coerced_tests.rb

@@ -879,15 +879,15 @@ def test_relations_dont_load_all_records_in_inspect_coerced
   # so we are skipping all together.
   coerce_tests! :test_empty_complex_chained_relations
 
-  # Can't apply offset withour ORDER
+  # Can't apply offset without ORDER
   coerce_tests! %r{using a custom table affects the wheres}
   test 'using a custom table affects the wheres coerced' do
     post = posts(:welcome)
 
     assert_equal post, custom_post_relation.where!(title: post.title).order(:id).take
   end
 
-  # Can't apply offset withour ORDER
+  # Can't apply offset without ORDER
   coerce_tests! %r{using a custom table with joins affects the joins}
   test 'using a custom table with joins affects the joins coerced' do
     post = posts(:welcome)
@@ -1151,10 +1151,21 @@ class CollectionCacheKeyTest < ActiveRecord::TestCase
 
 
 
+require "models/book"
 module ActiveRecord
   class StatementCacheTest < ActiveRecord::TestCase
     # Getting random failures.
     coerce_tests! :test_find_does_not_use_statement_cache_if_table_name_is_changed
+
+    # Need to remove index as SQL Server considers NULLs on a unique-index to be equal unlike PostgreSQL/MySQL/SQLite.
+    coerce_tests! :test_statement_cache_values_differ
+    def test_statement_cache_values_differ_coerced
+      Book.connection.remove_index(:books, column: [:author_id, :name])
+
+      original_test_statement_cache_values_differ
+    ensure
+      Book.connection.add_index(:books, [:author_id, :name], unique: true)
+    end
   end
 end
 
@@ -1264,3 +1275,47 @@ class DatabaseTasksTruncateAllTest < ActiveRecord::TestCase
     coerce_tests! :test_truncate_tables
   end
 end
+
+
+require "models/book"
+class EnumTest < ActiveRecord::TestCase
+  # Need to remove index as SQL Server considers NULLs on a unique-index to be equal unlike PostgreSQL/MySQL/SQLite.
+  coerce_tests! %r{enums are distinct per class}
+  test "enums are distinct per class coerced" do
+    Book.connection.remove_index(:books, column: [:author_id, :name])
+
+    send(:'original_enums are distinct per class')
+  ensure
+    Book.connection.add_index(:books, [:author_id, :name], unique: true)
+  end
+
+  # Need to remove index as SQL Server considers NULLs on a unique-index to be equal unlike PostgreSQL/MySQL/SQLite.
+  coerce_tests! %r{creating new objects with enum scopes}
+  test "creating new objects with enum scopes coerced" do
+    Book.connection.remove_index(:books, column: [:author_id, :name])
+
+    send(:'original_creating new objects with enum scopes')
+  ensure
+    Book.connection.add_index(:books, [:author_id, :name], unique: true)
+  end
+
+  # Need to remove index as SQL Server considers NULLs on a unique-index to be equal unlike PostgreSQL/MySQL/SQLite.
+  coerce_tests! %r{enums are inheritable}
+  test "enums are inheritable coerced" do
+    Book.connection.remove_index(:books, column: [:author_id, :name])
+
+    send(:'original_enums are inheritable')
+  ensure
+    Book.connection.add_index(:books, [:author_id, :name], unique: true)
+  end
+
+  # Need to remove index as SQL Server considers NULLs on a unique-index to be equal unlike PostgreSQL/MySQL/SQLite.
+  coerce_tests! %r{declare multiple enums at a time}
+  test "declare multiple enums at a time coerced" do
+    Book.connection.remove_index(:books, column: [:author_id, :name])
+
+    send(:'original_declare multiple enums at a time')
+  ensure
+    Book.connection.add_index(:books, [:author_id, :name], unique: true)
+  end
+end

test/support/coerceable_test_sqlserver.rb

@@ -19,21 +19,28 @@ def coerce_tests!(*methods)
         end
 
         def coerce_all_tests!
-          once = false
           instance_methods(false).each do |method|
             next unless method.to_s =~ /\Atest/
             undef_method(method)
-            once = true
           end
           STDOUT.puts "🙉 🙈 🙊  Undefined all tests: #{self.name}"
         end
 
         private
 
-        def coerced_test_warning(method)
-          method = instance_methods(false).select { |m| m =~ method } if method.is_a?(Regexp)
+        def coerced_test_warning(test_to_coerce)
+          if test_to_coerce.is_a?(Regexp)
+            method = instance_methods(false).select { |m| m =~ test_to_coerce }
+          else
+            method = test_to_coerce
+          end
+
           Array(method).each do |m|
-            result = undef_method(m) if m && method_defined?(m)
+            result = if m && method_defined?(m)
+                       alias_method("original_#{test_to_coerce.inspect.tr('/\:"', '')}", m)
+                       undef_method(m)
+                     end
+
             if result.blank?
               STDOUT.puts "🐳  Unfound coerced test: #{self.name}##{m}"
             else