datetime without precision now has default of 6

Author: mgrunberg

test/cases/coerced_tests.rb

@@ -542,6 +542,34 @@ def test_create_table_with_defaults_coerce
         assert_equal 1, four.default
         assert_equal "hello", five.default
       end
+
+      # Rails adds precision 6 by default, sql server uses datetime2 for datetimes with precision
+      coerce_tests! :test_add_column_with_postgresql_datetime_type
+      def test_add_column_with_postgresql_datetime_type_coerced
+        connection.create_table :testings do |t|
+          t.column :foo, :datetime
+        end
+
+        column = connection.columns(:testings).find { |c| c.name == "foo" }
+
+        assert_equal :datetime, column.type
+        assert_equal "datetime2(6)", column.sql_type
+      end
+
+      # timestamp is datetime with default limit
+      coerce_tests! :test_change_column_with_timestamp_type
+      def test_change_column_with_timestamp_type_coerced
+        connection.create_table :testings do |t|
+          t.column :foo, :datetime, null: false
+        end
+
+        connection.change_column :testings, :foo, :timestamp
+
+        column = connection.columns(:testings).find { |c| c.name == "foo" }
+
+        assert_equal :datetime, column.type
+        assert_equal "datetime", column.sql_type
+      end
     end
   end
 end

test/cases/schema_dumper_test_sqlserver.rb

@@ -67,7 +67,7 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     _(columns["float_col"].sql_type).must_equal        "float"
     _(columns["string_col"].sql_type).must_equal       "nvarchar(4000)"
     _(columns["text_col"].sql_type).must_equal         "nvarchar(max)"
-    _(columns["datetime_col"].sql_type).must_equal     "datetime"
+    _(columns["datetime_col"].sql_type).must_equal     "datetime2(6)"
     _(columns["timestamp_col"].sql_type).must_equal    "datetime"
     _(columns["time_col"].sql_type).must_equal         "time(7)"
     _(columns["date_col"].sql_type).must_equal         "date"
@@ -79,7 +79,7 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     assert_line :float_col,       type: "float",        limit: nil,          precision: nil,  scale: nil, default: nil
     assert_line :string_col,      type: "string",       limit: nil,          precision: nil,  scale: nil, default: nil
     assert_line :text_col,        type: "text",         limit: nil,          precision: nil,  scale: nil, default: nil
-    assert_line :datetime_col,    type: "datetime",     limit: nil,          precision: nil,  scale: nil, default: nil
+    assert_line :datetime_col,    type: "datetime",     limit: nil,          precision: 6,    scale: nil, default: nil
     assert_line :timestamp_col,   type: "datetime",     limit: nil,          precision: nil,  scale: nil, default: nil
     assert_line :time_col,        type: "time",         limit: nil,          precision: 7,    scale: nil, default: nil
     assert_line :date_col,        type: "date",         limit: nil,          precision: nil,  scale: nil, default: nil