Rails 6.1: Fix 'TypeError: can't quote ActiveRecord::Relation::QueryAttribute' (#883)

* don't patch unprepared statements

took the idea from

rails/rails@157f6a6#diff-39e2986a9d501a5ce3587a8d5944feb67c91e777f44270627850c219709d6510

and the fact that SubstituteCollector is only used for
unprepared_statements (see https://github.com/rails/rails/blob/v6.1.0/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb#L729)

* handle explain with ::ActiveRecord::Relation::QueryAttribute binds

Idea took from
rails/rails@157f6a6#diff-137c2c919e7860732301c49c60a700517455564bf463ff036756fb31c02a60e5

* add changelog entry

* apply suggestion

Author: mgrunberg

CHANGELOG.md

@@ -14,6 +14,7 @@
 - [#881](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/881) Dump column collation to schema.rb and allow collation changes using column_change
 - [#891](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/891) Add support for if_not_exists to indexes
 - [#892](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/892) Add support for if_exists on remove_column
+- [#883](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/885) Fix quoting of ActiveRecord::Relation::QueryAttribute and ActiveModel::Attributes
 
 #### Changed
 

lib/active_record/connection_adapters/sqlserver/core_ext/explain.rb

@@ -27,7 +27,12 @@ def unprepare_sqlserver_statement(sql, binds)
             executesql = executesql.match(SQLSERVER_STATEMENT_REGEXP).to_a[1]
 
             binds.each_with_index do |bind, index|
-              value = connection.quote(bind)
+
+              value = if bind.is_a?(::ActiveModel::Attribute)  then
+                connection.quote(bind.value_for_database)
+              else
+                connection.quote(bind)
+              end
               executesql = executesql.sub("@#{index}", value)
             end
 

lib/arel/visitors/sqlserver.rb

@@ -79,14 +79,16 @@ def visit_Arel_Nodes_HomogeneousIn(o, collector)
 
         if values.empty?
           collector << @connection.quote(nil)
-        else
+        elsif @connection.prepared_statements
           # Monkey-patch start. Add query attribute bindings rather than just values.
           column_name = o.column_name
           column_type = o.attribute.relation.type_for_attribute(o.column_name)
           attrs = values.map { |value| ActiveRecord::Relation::QueryAttribute.new(column_name, value, column_type) }
 
           collector.add_binds(attrs, &bind_block)
           # Monkey-patch end.
+        else
+          collector.add_binds(values, &bind_block)
         end
 
         collector << ")"