Allow AbstractAdapter to detect sqlserver connection (#1111)

Allow AbstractAdapter to detect sqlserver connection

Co-authored-by: Alexandre Overtus <3729387+aovertus@users.noreply.github.com>

Author: aovertus

lib/active_record/connection_adapters/sqlserver/core_ext/abstract_adapter.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module ActiveRecord
+  module ConnectionAdapters
+    module SQLServer
+      module CoreExt
+        module AbstractAdapter
+          def sqlserver?
+            false
+          end
+        end
+      end
+    end
+  end
+end
+
+ActiveSupport.on_load(:active_record) do
+  mod = ActiveRecord::ConnectionAdapters::SQLServer::CoreExt::AbstractAdapter
+  ActiveRecord::ConnectionAdapters::AbstractAdapter.prepend(mod)
+end

lib/active_record/connection_adapters/sqlserver/transaction.rb

@@ -5,14 +5,12 @@
 module ActiveRecord
   module ConnectionAdapters
     module SQLServerTransaction
-      private
+      delegate :sqlserver?, to: :connection, prefix: true
 
-      def sqlserver?
-        connection.respond_to?(:sqlserver?) && connection.sqlserver?
-      end
+      private
 
       def current_isolation_level
-        return unless sqlserver?
+        return unless connection_sqlserver?
 
         level = connection.user_options_isolation_level
         # When READ_COMMITTED_SNAPSHOT is set to ON,
@@ -50,7 +48,7 @@ def rollback
       private
 
       def reset_starting_isolation_level
-        if sqlserver? && starting_isolation_level
+        if connection_sqlserver? && starting_isolation_level
           connection.set_transaction_isolation_level(starting_isolation_level)
         end
       end

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -12,6 +12,7 @@
 require "active_record/connection_adapters/sqlserver/core_ext/attribute_methods"
 require "active_record/connection_adapters/sqlserver/core_ext/finder_methods"
 require "active_record/connection_adapters/sqlserver/core_ext/preloader"
+require "active_record/connection_adapters/sqlserver/core_ext/abstract_adapter"
 require "active_record/connection_adapters/sqlserver/version"
 require "active_record/connection_adapters/sqlserver/type"
 require "active_record/connection_adapters/sqlserver/database_limits"
@@ -100,7 +101,7 @@ def initialize(...)
         super
 
         @config[:tds_version] = "7.3" unless @config[:tds_version]
-        @config[:appname] = rails_application_name unless @config[:appname]
+        @config[:appname] = self.class.rails_application_name unless @config[:appname]
         @config[:login_timeout] = @config[:login_timeout].present? ? @config[:login_timeout].to_i : nil
         @config[:timeout] = @config[:timeout].present? ? @config[:timeout].to_i / 1000 : nil
         @config[:encoding] = @config[:encoding].present? ? @config[:encoding] : nil