New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest Rubies on Travis #104

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
3 participants
@koic
Contributor

koic commented Mar 16, 2017

No description provided.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Mar 16, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot commented Mar 16, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@koic

This comment has been minimized.

Show comment
Hide comment
@koic

koic Mar 16, 2017

Contributor

Travis CI has failed with the following matrix.

  • Ruby 2.4 / Rails 4.0 (Arel 4.0)
  • Ruby 2.4 / Rails 4.1 (Arel 5.0)
TypeError (Cannot visit Integer):
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/visitor.rb:28:in `rescue in visit'
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/visitor.rb:22:in `visit'
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/to_sql.rb:330:in `visit_Arel_Nodes_Limit'
https://travis-ci.org/rails/activerecord-session_store/builds/211658656

https://travis-ci.org/rails/activerecord-session_store/builds/211658656

The reason I think about is that the following PR is not backported to Arel 4.0 and Arel 5.0.

rails/arel#437

But I think these backports are not necessary. Because, as far as I know, Rails 4.0 and Rails 4.1 are not already supported.

Therefore, I propose to dropped support for Rails 4.0 and Rails 4.1 in this travis.yml.

What do you think about this?

Contributor

koic commented Mar 16, 2017

Travis CI has failed with the following matrix.

  • Ruby 2.4 / Rails 4.0 (Arel 4.0)
  • Ruby 2.4 / Rails 4.1 (Arel 5.0)
TypeError (Cannot visit Integer):
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/visitor.rb:28:in `rescue in visit'
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/visitor.rb:22:in `visit'
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/to_sql.rb:330:in `visit_Arel_Nodes_Limit'
https://travis-ci.org/rails/activerecord-session_store/builds/211658656

https://travis-ci.org/rails/activerecord-session_store/builds/211658656

The reason I think about is that the following PR is not backported to Arel 4.0 and Arel 5.0.

rails/arel#437

But I think these backports are not necessary. Because, as far as I know, Rails 4.0 and Rails 4.1 are not already supported.

Therefore, I propose to dropped support for Rails 4.0 and Rails 4.1 in this travis.yml.

What do you think about this?

@rafaelfranca rafaelfranca merged commit ac5ddf6 into rails:master May 11, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@koic koic deleted the koic:use_latest_rubies branch May 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment