Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use the latest Rubies on Travis #104
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Travis CI has failed with the following matrix.
TypeError (Cannot visit Integer): /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-188.8.131.5240414130214/lib/arel/visitors/visitor.rb:28:in `rescue in visit' /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-184.108.40.20640414130214/lib/arel/visitors/visitor.rb:22:in `visit' /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-220.127.116.1140414130214/lib/arel/visitors/to_sql.rb:330:in `visit_Arel_Nodes_Limit' https://travis-ci.org/rails/activerecord-session_store/builds/211658656
The reason I think about is that the following PR is not backported to Arel 4.0 and Arel 5.0.
But I think these backports are not necessary. Because, as far as I know, Rails 4.0 and Rails 4.1 are not already supported.
Therefore, I propose to dropped support for Rails 4.0 and Rails 4.1 in this travis.yml.
What do you think about this?