Skip to content

Conversation

@koic
Copy link
Contributor

@koic koic commented Mar 16, 2017

No description provided.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@koic
Copy link
Contributor Author

koic commented Mar 16, 2017

Travis CI has failed with the following matrix.

  • Ruby 2.4 / Rails 4.0 (Arel 4.0)
  • Ruby 2.4 / Rails 4.1 (Arel 5.0)
TypeError (Cannot visit Integer):
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/visitor.rb:28:in `rescue in visit'
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/visitor.rb:22:in `visit'
  /home/travis/build/rails/activerecord-session_store/gemfiles/vendor/bundle/ruby/2.4.0/gems/arel-5.0.1.20140414130214/lib/arel/visitors/to_sql.rb:330:in `visit_Arel_Nodes_Limit'
https://travis-ci.org/rails/activerecord-session_store/builds/211658656

https://travis-ci.org/rails/activerecord-session_store/builds/211658656

The reason I think about is that the following PR is not backported to Arel 4.0 and Arel 5.0.

rails/arel#437

But I think these backports are not necessary. Because, as far as I know, Rails 4.0 and Rails 4.1 are not already supported.

Therefore, I propose to dropped support for Rails 4.0 and Rails 4.1 in this travis.yml.

What do you think about this?

@koic koic force-pushed the use_latest_rubies branch from e7f9d2c to 94f7d56 Compare April 2, 2017 13:50
@koic koic force-pushed the use_latest_rubies branch from 94f7d56 to 2b74468 Compare May 3, 2017 06:42
@rafaelfranca rafaelfranca merged commit ac5ddf6 into rails:master May 11, 2017
@koic koic deleted the use_latest_rubies branch May 11, 2017 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants