Include response object in error when response is HTML and there is JSON::ParserError exception

[marisveide]

Steps to reproduce:

1. Make a REST API endpoint which supposedly fails, and returns HTML response (instead of JSON). Add a rescue block to catch all errors and get the error object from it.
2. Make the request with ActiveResource to that REST API endpoint.
3. See that the request blows up with an exception JSON::ParserError.
4. See that in the error object in the rescue block doesn't have a response attribute.

Expected result:

The error object should ideally have the request and response objects attributes, so that we can log them, and properly react to such cases depending on the request and response attributes, headers, etc.

Code place where the issue is:

It's in file:
https://github.com/rails/activeresource/blob/master/lib/active_resource/base.rb

This code fragment:

        # Find every resource
        def find_every(options)
          begin
            case from = options[:from]
            when Symbol
              instantiate_collection(get(from, options[:params]), options[:params])
            when String
              path = "#{from}#{query_string(options[:params])}"
              instantiate_collection(format.decode(connection.get(path, headers).body) || [], options[:params])
            else
              prefix_options, query_options = split_options(options[:params])
              path = collection_path(prefix_options, query_options)
              instantiate_collection((format.decode(connection.get(path, headers).body) || []), query_options, prefix_options)
            end
          rescue ActiveResource::ResourceNotFound
            # Swallowing ResourceNotFound exceptions and return nil - as per
            # ActiveRecord.
            nil
          end
        end

This call fails:

format.decode(connection.get(path, headers).body

The call is chained, so the request and response objects are not captured to a raised error, and cannot be accessed if format.decode raises an exception.

Suggested solution:

module ActiveResource

  class ResponseError < StandardError
    attr_reader :response

    def initialize(response, message = nil)
      @response = response
      @message = message
    end

    def to_s
      @message
    end
  end

end

Raise the ResponseError when there is an error parsing response JSON.

Would be really valuable if this can be solved.

Thanks so much!

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.

If it is an issue and you can still reproduce this error on the master branch,
please reply with all of the information you have about it in order to keep the issue open.

If it is a pull request and you are still interested on having it merged please make sure it can be merged clearly.

Thank you for all your contributions.