Skip to content

Include ruby 2.6 in Travis test matrix #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2019
Merged

Include ruby 2.6 in Travis test matrix #306

merged 1 commit into from
Aug 19, 2019

Conversation

@eitoball
Copy link
Contributor

@eitoball eitoball commented Mar 3, 2019

This PR includes ruby 2.6 in Travis CI test matrix.

rafaelfranca
rafaelfranca reviewed Mar 20, 2019
View reviewed changes
.travis.yml
- rvm: 2.4.5
- env: BRANCH=master
include:
- rvm: 2.2.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to remove those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because 2.2.10 and 2.3.8 are not in rvm:.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, they are not in the main matrix and this is why we are adding in the include: matrix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... include... I was thinking of exclude

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I am not sure why build on Travis CI is failing. It is passing on https://travis-ci.org/eitoball/activeresource/builds/508732442

@eitoball eitoball force-pushed the include-ruby-2.6.1-in-travis-test-matrix branch from e888497 to 9df09cc Compare March 20, 2019 03:41
@eitoball eitoball force-pushed the include-ruby-2.6.1-in-travis-test-matrix branch from 9df09cc to 9a9207e Compare May 15, 2019 03:16
@rails-bot
Copy link

rails-bot bot commented Aug 13, 2019

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.

If it is an issue and you can still reproduce this error on the master branch,
please reply with all of the information you have about it in order to keep the issue open.

If it is a pull request and you are still interested on having it merged please make sure it can be merged clearly.

Thank you for all your contributions.

@rails-bot rails-bot bot added the stale label Aug 13, 2019
@amatsuda
Copy link
Member

@eitoball I'm sorry I just pushed 9aa30b1 without noticing that this PR already exists. Could you rebase and push-f if you're still willing push the rest of this PR?

@rails-bot rails-bot bot removed the stale label Aug 19, 2019
@eitoball eitoball force-pushed the include-ruby-2.6.1-in-travis-test-matrix branch from 9a9207e to c6d919c Compare August 19, 2019 07:00
@eitoball
Copy link
Contributor Author

@amatsuda I just rebased and force-pushed. Thank you for checking out.

@amatsuda amatsuda merged commit ea6f109 into rails:master Aug 19, 2019
@amatsuda
Copy link
Member

@eitoball Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaelfranca rafaelfranca rafaelfranca left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eitoball @amatsuda @rafaelfranca