Coder#load: Conditionally call Formats.remove_root
#431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to [rails#420][] Problem --- While the `Coder` class and `Serialization` module aim to comply with Active Record, there's still potential for that compatibility to drift of break without sufficient test coverage. The `Coder#load` implementation does not support inferring the correct `@persisted` value from payloads with root-level keys. For example, `{ "person": { "id": 1 } }` will not be inferred as persisted in the same way that `{ "id": 1 }` will. Proposal --- To resolve the `@persisted` value, call `Format.remove_root` to ensure that the payload consists of only attributes. [rails#420]: rails#420
seanpdoyle
force-pushed
the
coder-remove-root
branch
from
21b1293 to
4e7d675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #420
Problem
While the
Coderclass andSerializationmodule aim to comply with Active Record, there's still potential for that compatibility to drift of break without sufficient test coverage.The
Coder#loadimplementation does not support inferring the correct@persistedvalue from payloads with root-level keys. For example,{ "person": { "id": 1 } }will not be inferred as persisted in the same way that{ "id": 1 }will.Proposal
To resolve the
@persistedvalue, callFormat.remove_rootto ensure that the payload consists of only attributes.