Rails 6 support #114
Merged
Rails 6 support #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2019
larouxn
commented
Apr 4, 2019
rafaelfranca
reviewed
Apr 4, 2019
Author
|
I removed the seemingly unnecessary files from here and rails/rails#35852. However, we're now hitting the "file not found" errors from before. My apologies, not quite sure what's wrong here. rails/rails#35852 is 💚btw. |
|
Thanks - removed all of my "git:" strings and upgraded most (some are dependent of other gems) of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is prepare
coffee-railsfor Rails 6. The main issue with Rails 6, as far as this gem is concerned, is CS/JS isn't generated by default as the default changed in rails/rails#33079This PR adds the appropriate
--javascript-engine=coffeeflag to the one generation test without it.The aforementioned CS/JS generation point is being addressed by rails/rails#35852.
@rafaelfranca