Skip to content

namespaced_file_path was removed from railties #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2020
Merged

namespaced_file_path was removed from railties #471

merged 1 commit into from
Mar 16, 2020

Conversation

@kdiogenes
Copy link
Contributor

@kdiogenes kdiogenes commented Nov 22, 2019

No description provided.

@kdiogenes kdiogenes mentioned this pull request Nov 22, 2019
Closed
@olleolleolle
Copy link
Contributor

olleolleolle commented Mar 16, 2020

This follows Rails' change, here's a direct link to how Rails did when they switched away from the removed method:

rails/rails@595fa6e

olleolleolle
olleolleolle approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafaelfranca rafaelfranca merged commit edbb333 into rails:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@olleolleolle olleolleolle olleolleolle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kdiogenes @olleolleolle @rafaelfranca