Update asset digests when sourcemaps change #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sourcemaps change, their digest will change, and the generated URL in the `# sourceMappingURL` comment will change. Therefore, it's important that the digest of the original asset also changes, so that caches can be invalidated correctly. This change makes use of the existing `#referenced_by` API in the SourceMappingUrls compiler, and implements the tests in a similar way to 59406ab.
davidtaylorhq
force-pushed
the
sourcemap-digest
branch
from
9850a8e to
8b0ff49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sourcemaps change, their digest will change, and the generated URL in the
# sourceMappingURLcomment will change. Therefore, it's important that the digest of the original asset also changes, so that caches can be invalidated correctly.This change makes use of the existing
#referenced_byAPI in the SourceMappingUrls compiler, and implements the tests in a similar way to 59406ab.Resolves #259