[Rails 3.1 edge] ActionDispatch::ClosedError: Cannot modify cookies because it was closed. This means it was already streamed back to the client or converted to HTTP headers.

[dreamr]

This is related to the new streaming.

Whenever I post to user_session (using authlogic) via request specs (or for that matter cucumber or controller specs rendering views) For now I have pended these things. I'm betting this is going to be similar to the flash issue.

I don't have time just now to look into this more then I have, maybe this weekend if no one gets to it.

[sikachu]

Do you have any middleware that accessing the cookie?

[dreamr]

Nope, it straight authlogic with the following helpers: https://gist.github.com/1003373
my spec helper: https://gist.github.com/1003383
my request spec: https://gist.github.com/1003385
My user session model: https://gist.github.com/1003387
my factories: https://gist.github.com/1003388

It was working till I upgraded to 3.1 last week.

I have tried quite a few work arounds with no luck yet.

[sikachu]

Thank you. I'll dig around to see if I can reproduce.

Anyway, just to make sure, you're on the latest version of rspec-rails (2.6.1) right? I think all versions before 2.6.1 is broken on Rails 3.1.

[dreamr]

yup.

On Wed, Jun 1, 2011 at 4:33 PM, sikachu <
reply@reply.github.com>wrote:

Thank you. I'll dig around to see if I can reproduce.

Anyway, just to make sure, you're on the latest version of rspec-rails
(2.6.1) right? I think all versions before 2.6.1 is broken on Rails 3.1.

Reply to this email directly or view it on GitHub:
#1452 (comment)

E. James OKelly

Chief Technologist
RubyistLabs, llc.

+1 760 851 1046
james@rubyloves.me

[spastorino]

@dreamr can you gave us a github repo of a minimal app with the failing test?

[aeden]

I'm seeing the same thing. I also use authlogic. I am seeing the issue with Cucumber features though.

[josevalim]

It seems to be an authlogic issue? It seems to be storing cookies somewhere and modifying them after they are sent back.

[spastorino]

It would help if any of you guys can share an application that shows the error

[aeden]

I'll try to set up an example.

[aeden]

@dreamr are you also using Factory Girl? Looking at my failing Cucumber scenarios I see that they are actually failing when a User instance is being created with Factory(:user). So far in a test app I've created the same problem does not manifest with Cucumber and Authlogic alone. Still digging...

[aeden]

FactoryGirl was a red herring. I've reproduced the error without it. I'll publish the repo momentarily.

[aeden]

Here's the repo: https://github.com/aeden/rails31_authlogic.

To get it blow up run cucumber.

[moiristo]

Same problem here, using ActionController::IntegrationTest, factory_girl, capybara & authlogic (no cucumber). I'll try to find out what's happening in the authlogic after_save callback. Trace:

ActionDispatch::ClosedError: Cannot modify cookies because it was closed. This means it was already streamed back to the client or converted to HTTP headers.
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/actionpack-3.1.0.rc1/lib/action_dispatch/middleware/cookies.rb:157:in `[]='
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/authlogic-3.0.3/lib/authlogic/session/cookies.rb:167:in `save_cookie'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activesupport-3.1.0.rc1/lib/active_support/callbacks.rb:395:in `_run_after_save_callbacks'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activesupport-3.1.0.rc1/lib/active_support/callbacks.rb:81:in `run_callbacks'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/authlogic-3.0.3/lib/authlogic/session/callbacks.rb:87:in `after_save'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/authlogic-3.0.3/lib/authlogic/session/existence.rb:71:in `save'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/authlogic-3.0.3/lib/authlogic/session/existence.rb:30:in `create'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/authlogic-3.0.3/lib/authlogic/acts_as_authentic/session_maintenance.rb:113:in `create_session'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/authlogic-3.0.3/lib/authlogic/acts_as_authentic/session_maintenance.rb:103:in `maintain_sessions'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activesupport-3.1.0.rc1/lib/active_support/callbacks.rb:418:in `_run_save_callbacks'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activesupport-3.1.0.rc1/lib/active_support/callbacks.rb:81:in `run_callbacks'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/callbacks.rb:264:in `create_or_update'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/persistence.rb:53:in `save!'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/validations.rb:56:in `save!'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/attribute_methods/dirty.rb:33:in `save!'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/transactions.rb:246:in `block in save!'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/transactions.rb:295:in `block in with_transaction_returning_status'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/connection_adapters/abstract/database_statements.rb:183:in `transaction'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/transactions.rb:208:in `transaction'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/transactions.rb:293:in `with_transaction_returning_status'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/activerecord-3.1.0.rc1/lib/active_record/transactions.rb:246:in `save!'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/factory_girl-1.3.3/lib/factory_girl/proxy/create.rb:6:in `result'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/factory_girl-1.3.3/lib/factory_girl/factory.rb:330:in `run'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/factory_girl-1.3.3/lib/factory_girl/factory.rb:273:in `create'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/factory_girl-1.3.3/lib/factory_girl/factory.rb:304:in `default_strategy'
    /Users/nedforce/.rvm/gems/ruby-1.9.2-p180@rails31/gems/factory_girl-1.3.3/lib/factory_girl.rb:20:in `Factory'
    /Users/nedforce/projects/wizer/test/integration/authentication_test.rb:6:in `block in <class:AuthenticationTest>'

[moiristo]

This has not been fixed in RC4 either. Is this an authlogic or an actiondispatch issue? Note that I found out that it works when running one test at a time, but running 'rake test:integration' when having multiple tests or when running one test class with multiple test definitions in it, it fails.