Skip to content

Conversation

@alexcameron89
Copy link
Member

@alexcameron89 alexcameron89 commented Jun 24, 2016

Module#thread_mattr_accessor is referenced in ActiveSupport::PerThreadRegistry documentation, and the link makes it easier to find the documentation for the method and friends.

@rails-bot
Copy link

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

@maclover7
Copy link
Contributor

Hmm, is this working for you locally? When I run rdoc locally and pull up the PerThreadRegistry documentation page, this rdoc-ref doesn't work for me :/

@alexcameron89
Copy link
Member Author

I checked it with bundle exec rake rdoc and it works. Can you try it with that?

@maclover7
Copy link
Contributor

maclover7 commented Jun 24, 2016

👍 works for me now. Just realized I had been running rdoc off of master, not off of your branch -- sorry for the troubles. :)

👍 Thank you for your contribution!

❤️ 💚 💙 💛 💜

@maclover7 maclover7 merged commit c1064b0 into rails:master Jun 24, 2016
@alexcameron89
Copy link
Member Author

Thank you! Y'all are awesome. 😄

@alexcameron89 alexcameron89 deleted the per_thread_registry branch June 24, 2016 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants