Optimize ActiveJob ObjectSerializer #55663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same benchmark than in b6c472a Since 1f8a0c0 had to be reverted as it changes the order of keys in the payload, the next bext thing we can do is to precompute the base hash. The gain is modest but the patch is simple. ``` ruby 3.5.0dev (2025-08-27T10:41:07Z master 5257e1298c) +YJIT +PRISM [arm64-darwin24] Warming up -------------------------------------- aj-obj-serializer-template 23.500k i/100ms Calculating ------------------------------------- aj-obj-serializer-template 234.683k (± 0.7%) i/s (4.26 μs/i) - 1.175M in 5.007012s Comparison: aj-obj-serializer-template: 234682.8 i/s previous-commit: 223601.1 i/s - 1.05x slower ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same benchmark than in b6c472a / #55583
Since 1f8a0c0 had to be reverted as it changes the order of keys in the payload, the next bext thing we can do is to precompute the base hash.
The gain is modest but the patch is simple.