[Fix #55513] parallel tests hanging when worker processes die abruptly #55794
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
fix-55513
branch
from
ac93f2b to
de07dc6
Compare
joshuay03
commented
Sep 28, 2025
| Process.kill("KILL", worker_pids.first) | ||
| sleep 0.25 | ||
|
|
||
| Timeout.timeout(2.5, Minitest::Assertion, "Expected shutdown to not hang") { parallelization.shutdown } |
byroot
approved these changes
Sep 29, 2025
byroot
added a commit
that referenced
this pull request
Sep 29, 2025
[Fix #55513] parallel tests hanging when worker processes die abruptly
byroot
added a commit
that referenced
this pull request
Sep 29, 2025
[Fix #55513] parallel tests hanging when worker processes die abruptly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Closes #55513.
Detail
When parallel tests are running and a worker process dies abruptly (e.g., OOM killed,
kill -9), the test suite would hang forever waiting for the dead worker to callstop_worker, which it never could.The fix detects dead workers during shutdown by using
Process.waitpidwithWNOHANGto check which processes have exited, then removes them from the server's active worker list before waiting for remaining workers to finish. The server now tracks PIDs alongside worker IDs, allowing it to map dead processes back to their worker entries for cleanup.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]