Add link-local IP ranges to RemoteIp default proxies #55821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam12
force-pushed
the
link-local-remote-ip
branch
2 times, most recently
from
c1bc442 to
a206316
Compare
Link-local addresses (169.254.0.0/16 for IPv4 and fe80::/10 for IPv6) should be treated as trusted proxies by default, similar to private IP ranges, since they are non-routable and used for local network communication. Use of link-local IP addresses in tests were updated to use the 2001:db8::/32 netblock (RFC3849) to prevent conflict with the changes to the trusted proxies.
byroot
force-pushed
the
link-local-remote-ip
branch
from
a206316 to
0a6abea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Link-local addresses (169.254.0.0/16 for IPv4 and fe80::/10 for IPv6) should be treated as trusted proxies by default, similar to private IP ranges, since they are non-routable and used for local network communication.
Details
Use of link-local IP addresses in tests were updated to use the 2001:db8::/32 netblock (RFC3849) to prevent conflict with the changes to the trusted proxies.
I went through the blame and can't see why fe80::/8 was chosen for these to begin with.
Additional information
Seen in the wild on an application deployed as an Azure Web Application.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]