[Getting Started] Use .positive? for more explicit positive checks rather than implicitly field itself [ci skip] #55863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh183
changed the title
MatheusRich
reviewed
Oct 7, 2025
|
|
||
| ```erb | ||
| <% if product.inventory_count? %> | ||
| <% if product.inventory_count.positive? %> |
There was a problem hiding this comment.
Just double checking that this is never nil
There was a problem hiding this comment.
I'll double check in my tutorial code. If it is nil, maybe it's a good time to introduce default column values.
There was a problem hiding this comment.
Or I can do &.positive?, that's easier
There was a problem hiding this comment.
This was a real error to worry about. I added a default: 0 when introducing the migration to guard against this. As a bonus, it's another nice rails feature to throw in the getting started tutorial.
MatheusRich
approved these changes
Oct 7, 2025
|
This has been discussed before: #55344 |
|
Nice! Glad to know I wasn't the only person who thought that was a little confusing for beginners. |
…ther than implicitly field itself In the tutorial we use `product.inventory_count?` to check if the product is in stock. This is relying on implicit rails behavior that can be confusing and hard to reason about for newcomers. This change uses `product.inventory_count.positive?` instead, which is more explicit and easier to understand. I also standardized on using it throughout the tutorial for consistency.
harsh183
force-pushed
the
getting_started/standardize_on_positive_check
branch
from
2b24bf5 to
c55e428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
In the tutorial we use
product.inventory_count?to check if the product is in stock. This is relying on implicit rails behavior that can be confusing and hard to reason about for newcomers.Detail
This change uses
product.inventory_count.positive?instead, which is more explicit and easier to understand. I also standardized on using it throughout the tutorial for consistency.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]