Fix generator command for nested (namespaced) rails engine #27550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In rails#6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
rafaelfranca
reviewed
Jan 4, 2017
| end | ||
|
|
||
| def namespaced_path # :doc: | ||
| @namespaced_path ||= namespace.name.split("::").first.underscore | ||
| @namespaced_path ||= namespace.name.split("::").map(&:underscore) |
There was a problem hiding this comment.
Sorry. I had to revert because this method is public API and now it changes the return from a string to an array. Can you open a new PR keeping this method returning a string?
There was a problem hiding this comment.
Can you open a new PR keeping this method returning a string?
Sure!
mtsmfm
added a commit
to mtsmfm/rails
that referenced
this pull request
Jan 7, 2017
Rewrite rails#27550 085546d was reverted (b6ffb5e) because it change the return of `namespaced_path` from String to Array. ---------------- If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In rails#6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If we create nested (namespaced) rails engine such like bukkits-admin,
bin/rails g scaffold User name:string age:integerwill create
bukkits-admin/app/controllers/bukkits/users_controller.rbbut it should create
bukkits-admin/app/controllers/bukkits/admin/users_controller.rb.Other Information
In #6643, we changed
namespaced_pathas root pathbecause we supposed application_controller is always in root
but nested rails engine's application_controller will not.