Patch for bug on RubyGems 1.3.5 in 2 3 stable #3133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a magic comment and its source encoding doesn't match the default external encoding
…c comment renders a partial without one and its source encoding doesn't match the default external encoding
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
… serialize instances as hash of model name -> attributes hash rather than the bare attributes hash. [rails#2584 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Now works with :dependent => :destroy and includes unit tests for that case. Also includes better error messages when updating/deleting stale objects. [rails#1966 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
…state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
… same way as jeremy did with message verifier [rails#4517 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
…tions un-touched [rails#4514 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Signed-off-by: Pratik Naik <pratiknaik@gmail.com> Conflicts: activerecord/test/cases/nested_attributes_test.rb
[rails#4532 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
… rails_xss plugin [rails#3767 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
…eters and a hash. ht: Marc-André Lafortune [rails#4457 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Example:
add_index(:accounts, :name, :name => 'by_name', :length => 10)
=> CREATE INDEX by_name ON accounts(name(10))
add_index(:accounts, [:name, :surname], :name => 'by_name_surname', :length => {:name => 10, :surname => 15})
=> CREATE INDEX by_name_surname ON accounts(name(10), surname(15))
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
…]" (breaks the build) This reverts commit 3616141.
…resolved]" (breaks the build)" This reverts commit eababa3.
…x test since SQLite returns Float. [rails#4514 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
[rails#4529 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
…en the user uses select but does not specify the primary key Signed-off-by: José Valim <jose.valim@gmail.com>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
- it was broken after [commit](rails@e0eb8e9) - there's also [issue](https://rails.lighthouseapp.com/projects/8994/tickets/6634-railsrack-inconsistency-about-expires_afterexpires-cookie-option) - also: maybe it worth making Rack understand :expire_after as we duplicate same logic in [cookie_store](https://github.com/gmarik/rails/blob/v2.3.11/actionpack/lib/action_controller/session/cookie_store.rb#L114) Signed-off-by: José Valim <jose.valim@gmail.com>
…the find_by_* method. Closes issue rails#330. Commit fdfc8e3 introduced a bugfix to prevent additional values passed to a dynamic find_or_create_by_x methods from confusing the finder. This patch also broke the essential behavior of this method on an association by incorrectly sending arguments to the find_by_x methods. The finder method would always see its inputs as a single array of values instead of individual arguments, almost guaranteeing that the finder call would be incorrect, and that we'd always create a new record instead. This patch adds a splat operator to the parameter array we send along to the dynamic finder so that it receives its inputs correctly, and includes an additional test to ensure that repeated calls to find_or_create_by_x only creates one new record.
Dynamic find_or_create_by_x_and_y always creates new records in Rails 2.3.11
Patch for issue 6440 - Session Reset undefined method `destroy' for {}:Hash
…VER change the semantics of the parent (returning nil if default).
name and requirement. Better, just activate the spec for the dependency (1.8 only)
This may cause problems. I dunno. The real solution is to get rid of all of this mess and use gem paths properly.
+ Fixed deprecated usage in gemspecs. Bumped the version to 2.3.12 so I could test locally with actual installs. If this is bad form for this project, please beat me up and I'll split them out.
… This is the same API that ActiveModel ended up using and that won't be changing.
Fix OrderedHash merging with block given.
…sues/8800 on several projects when updating from Rails 2.3.10 to Rails 2.3.14 on RubyGems 1.3.5. The patch mentioned in the pull request here: rails#2818 seems to work properly, although that pull request seems to include a whole load of other commits.
|
How hard can it be to make a pull request for a stable branch... :/ |
|
I think you did something wrong here. It's having 250+ commits. you need to select proper branch. |
|
We are not fixing 2.3.x issues anymore. |
|
@arunagw: created a correct pull request: #3134
Oh yeah.. and maybe put on the actual website that you dropped support. OH! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on http://projects.puppetlabs.com/issues/8800 and #2818
Without it, my applications won't start at all (updated from Rails 2.3.10 to Rails 2.3.14)