Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include deserialized arguments in jobs returned by AJ test helpers #34204

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@XrXr
Copy link
Contributor

@XrXr XrXr commented Oct 12, 2018

Summary

assert_enqueued_with and assert_performed_with return a instantiated
instance of the matching job for further assertion (#21010).

Before this commit the argument method on the returned instance
returns a serialized version of the argument.

@rails-bot
Copy link

@rails-bot rails-bot commented Oct 12, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

`assert_enqueued_with` and `assert_performed_with` return a instantiated
instance of the matching job for further assertion (rails#21010).

Before this commit the `arguments` method on the returned instance
returns a serialized version of the arguments.
Copy link
Member

@gmcgibbon gmcgibbon left a comment

To be clear, the previous behaviour would include activejob serialization data like [1, 2, 3, {"keyword"=>true, "_aj_symbol_keys"=>["keyword"]}] which isn't important when asserting arguments of a job. 👍

@XrXr XrXr force-pushed the aj-test-helper-args branch from 78542ee to 3ebc229 Oct 12, 2018
Copy link
Contributor

@albertoalmagro albertoalmagro left a comment

Thanks @XrXr !

@rafaelfranca rafaelfranca merged commit d76d66f into rails:master Oct 24, 2018
2 checks passed
@XrXr XrXr deleted the aj-test-helper-args branch Oct 24, 2018
rafaelfranca added a commit that referenced this issue Oct 24, 2018
Include deserialized arguments in jobs returned by AJ test helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants