Include deserialized arguments in jobs returned by AJ test helpers #34204
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
`assert_enqueued_with` and `assert_performed_with` return a instantiated instance of the matching job for further assertion (rails#21010). Before this commit the `arguments` method on the returned instance returns a serialized version of the arguments.
XrXr
force-pushed
the
aj-test-helper-args
branch
from
78542ee to
3ebc229
Compare
Include deserialized arguments in jobs returned by AJ test helpers
Summary
assert_enqueued_withandassert_performed_withreturn a instantiatedinstance of the matching job for further assertion (#21010).
Before this commit the
argumentmethod on the returned instancereturns a serialized version of the argument.