New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend CVE note and security guide section wordings #34392

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@gmcgibbon
Member

gmcgibbon commented Nov 6, 2018

Summary

Followup on #34388. I changed the first sentence in the security guide section and moved the gemspec notes just above the dependency lines with a link to the edge security guide.

r? @matthewd
cc @kaspth, @rafaelfranca

Amend CVE note and security guide section wordings
Reword first sentence of dep management and CVE section of
security guide. Also, reword and move gemspec notes above deps.

[ci skip]

@rafaelfranca rafaelfranca merged commit 133e0ba into rails:master Nov 6, 2018

1 check passed

codeclimate All good!
Details

@gmcgibbon gmcgibbon deleted the gmcgibbon:gem_security_note_amend branch Nov 6, 2018

@matthewd

This comment has been minimized.

Member

matthewd commented Nov 7, 2018

👌 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment