Deprecate passing a Class to ActiveSupport::Digest.hash_digest_class
#39540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipulnsward
force-pushed
the
digest-deprecation
branch
4 times, most recently
from
53378c7 to
8af9005
Compare
…cated in favour of String.
Before:
ActiveSupport::Digest.hash_digest_class = OpenSSL::Digest::SHA256
After:
ActiveSupport::Digest.hash_digest_class = "SHA256"
Related discussions:
ruby/openssl#362
ruby/openssl#304
rails#39410
Sibling PR: rails#39504
vipulnsward
force-pushed
the
digest-deprecation
branch
from
8af9005 to
9742bd3
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate passing a Class to
ActiveSupport::Digest.hash_digest_classand instead accept a string.Related discussions:
ruby/openssl#362
ruby/openssl#304
#39410
Sibling PR: #39504
This will also be helpful to upcoming rotation of algorithms moving to SHA256