[ci skip] Add Bootstrap and Bulma to the CSS processors' list #43254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a few thoughts:
|
alexandreruban
force-pushed
the
bootstrap-bulma-css-processors
branch
from
1c85bb4 to
ff6c065
Compare
|
@ceritium thank you very much for your comments! I updated the PR according to #43255. I still think it's worth explicitly mentioning both Bulma and Bootstrap because they are two popular frameworks. A few hours ago, a new version of |
ceritium
approved these changes
Sep 20, 2021
dhh
pushed a commit
that referenced
this pull request
Sep 20, 2021
* main: [ci skip] Add Bootstrap and Bulma to the CSS processors' list (#43254) Add missing configuration to middleware test Add ActionDispatch::ServerTiming to the list of middlewares in test Add CHANGELOG entry for ServerTiming middleware [ci skip] Add Server Timing middleware (#36289) Don't overwrite default opts in rich_text_area_tag (#43156) Only call `wrap_parameters` if it's defined (#43259) Suggest a CSP that's compatible with Turbo + import map (#43227) Fix app generator tests Fix docs spacing Fix typo: integer numbers (not integral) Add `beginning_of_week` option to `weekday_options_for_select` Pluralize the heading on the index page generated with scaffold Move the parameter wrapper code to the ActionController::Railtie class Add explicit rendering to DiskController#update Fix update & destroy queries when default_scope is nillable with all_queries: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43251
Summary
When running
rails new --helpthebootstrapandbulmaoptions for CSS processors were not documented.The
rails new --css=bootstrapoption already works and therails new --css=bulmaoption will work in the cssbundling-rails next release thanks to this merged pull request.