Fix for Lighthouse ticket # 6334 : to_xml should render valid xml or raise an error all the time #445
Conversation
|
Shouldn't we just dasherize the keys or something like that? |
|
@josevalim I agree. @prakashmurthy, can you change this to dasherize keys, and I'll apply? |
|
Since dasherize method only replaces '_' with '-', and does not do anything to spaces, we are thinking of using gsub(' ','-').Is this OK? |
|
Used gsub instead of _dasherize method as there is another issue with _dasherize method being broken. #450 |
|
Thanks @prakashmurthy! I have fixed the _dasherize method, do you think your pull request could be refactored then? As the default is to dasherize, I don't even think we need to do anything, just add your tests. Could you please check? |
|
Thanks @josevalim. Refactored the code; now the change includes only the tests. Let me know if anything else needs to be done. |
Fix for Lighthouse ticket # 6334 : to_xml should render valid xml or raise an error all the time
Add Arel::Nodes::Casted to dot visitor
Raise a RuntimeException with custom message when hash key contains space. Old behavior was { "New York"=>33, :Versailles => 3231 }.to_xml created an xml which was invalid.