Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile to use 'debugger' instead of unmaintained 'ruby-debug19' #5835

Merged
merged 1 commit into from
Apr 16, 2012
Merged

Update Gemfile to use 'debugger' instead of unmaintained 'ruby-debug19' #5835

merged 1 commit into from
Apr 16, 2012

Conversation

asanghi
Copy link
Contributor

@asanghi asanghi commented Apr 13, 2012

...by-debug19 and move to debugger. Whats the consensus here? If we want better adoption on ruby1.9, please lets just use this fork.

… ruby-debug19 and move to debugger. Whats the consensus here? If we want better adoption on ruby1.9, please lets just use this fork.
@asanghi
Copy link
Contributor Author

asanghi commented Apr 16, 2012

/cc @josevalim @spastorino opinions?

jeremy added a commit that referenced this pull request Apr 16, 2012
Update Gemfile to use 'debugger' instead of unmaintained 'ruby-debug19'
@jeremy jeremy merged commit a0c2cfd into rails:master Apr 16, 2012
@kevinzen
Copy link

Nicely done. We're all using that one anyway.

@asanghi
Copy link
Contributor Author

asanghi commented Apr 17, 2012

Cherry pick into Rails3-2 as well please?

@jeremy
Copy link
Member

jeremy commented Apr 17, 2012

@asanghi Does debugger support 1.8 also, or 1.9 only?

@asanghi
Copy link
Contributor Author

asanghi commented Apr 17, 2012

From the initial looks of it, probably not (/cc @cldwalker ?). I suppose we could use the :platform option in the Gemfile to use debugger in 1.9 and ruby-debug in 1.8. Or do we want to keep the template Gemfile clean and simple? I'll try to send a pull with platforms and you can take the call? cool?

@asanghi
Copy link
Contributor Author

asanghi commented Apr 17, 2012

Actually in Rails 3.2 there is ruby code which inserts the correct debugging gem. Will send a proper patch. Also realized that there are some guides on master that can be updated.

@cldwalker
Copy link
Contributor

@jeremy @asanghi debugger only supports 1.9.x. I considered adding 1.8.7 support but ruby-debug works fine for that ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants