Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Disable Rack::Cache by default #7838

Merged
merged 3 commits into from Oct 5, 2012

Conversation

Projects
None yet
4 participants
Owner

guilleiguaran commented Oct 3, 2012

No description provided.

Owner

rafaelfranca commented Oct 3, 2012

👍

@frodsan frodsan commented on an outdated diff Oct 3, 2012

actionpack/CHANGELOG.md
@@ -2,8 +2,9 @@
* Failsafe exception returns text/plain. *Steve Klabnik*
-* Remove actionpack's rack-cache dependency and declare the
- dependency in the Gemfile.
+* Remove actionpack's rack-cache dependency and declare the dependency in the Gemfile.
+ `config.action_dispatch.rack_cache` should be set to true or to an options hash
@frodsan

frodsan Oct 3, 2012

Contributor

true.

@frodsan frodsan commented on an outdated diff Oct 3, 2012

actionpack/CHANGELOG.md
@@ -2,8 +2,9 @@
* Failsafe exception returns text/plain. *Steve Klabnik*
-* Remove actionpack's rack-cache dependency and declare the
- dependency in the Gemfile.
+* Remove actionpack's rack-cache dependency and declare the dependency in the Gemfile.
+ `config.action_dispatch.rack_cache` should be set to true or to an options hash
+ to enable Rack::Cache middleware
@frodsan

frodsan Oct 3, 2012

Contributor

Rack::Cache middleware**.** :)

@rafaelfranca rafaelfranca commented on an outdated diff Oct 3, 2012

actionpack/CHANGELOG.md
@@ -2,8 +2,9 @@
* Failsafe exception returns text/plain. *Steve Klabnik*
-* Remove actionpack's rack-cache dependency and declare the
- dependency in the Gemfile.
+* Remove actionpack's rack-cache dependency and declare the dependency in the Gemfile.
@rafaelfranca

rafaelfranca Oct 3, 2012

Owner

Action Pack

@rafaelfranca rafaelfranca and 1 other commented on an outdated diff Oct 3, 2012

actionpack/CHANGELOG.md
@@ -2,10 +2,16 @@
* Failsafe exception returns text/plain. *Steve Klabnik*
-* Remove actionpack's rack-cache dependency and declare the
+* `Rack::Cache` middleware is now disabled by default, to enable it you
+ should set `config.action_dispatch.rack_cache` to `true` or to an
+ options hash to enable it.
@rafaelfranca

rafaelfranca Oct 3, 2012

Owner

we can remove this to enable it in the end of sentence

@guilleiguaran

guilleiguaran Oct 3, 2012

Owner

right, I miss it

@rafaelfranca rafaelfranca commented on an outdated diff Oct 4, 2012

...ls/app/templates/config/environments/production.rb.tt
@@ -14,6 +14,11 @@
config.consider_all_requests_local = false
config.action_controller.perform_caching = true
+ # Enable Rack::Cache to put a simple HTTP cache in front of your application
+ # Add `rack-cache` to your Gemfile before of enable this.
@rafaelfranca

rafaelfranca Oct 4, 2012

Owner
# Add `rack-cache` to your Gemfile before enabling this.
Owner

rafaelfranca commented Oct 4, 2012

I did a minor english review.

Also please squash some commits.

@spastorino spastorino added a commit that referenced this pull request Oct 5, 2012

@spastorino spastorino Merge pull request #7838 from guilleiguaran/extract-rack-cache
Disable Rack::Cache by default
a8c8a08

@spastorino spastorino merged commit a8c8a08 into rails:master Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment