Honor sass.style and assets.css_compressor config settings #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and assets.css_compressor with default values if not otherwise set. This allows assets.css_compressor = :yui to actually work! Setting ||= :compressed is pointless if the style was initialized to :expanded at the beginning of the rail ties file. So it had to be moved to the else clause of the setup_compression initializer. Added an initializer to CssCompressor to allow for any compression style to be passed in, and then passing in from the railtie. It might be good to do the same for the other options in the compressor. The initialize method is already heading in this direction. Added another test fixture app, with different config settings set in deferent environments. Calling runcmd with different environments then allows for different config paths to be run.
drogus
added a commit
that referenced
this pull request
May 26, 2012
Honor sass.style and assets.css_compressor config settings
|
I'm curious about whether this needs to be applied to the master branch, I haven't tried it yet, but I wouldn't want the changes to regress in rails 4.0 |
|
@dgm yes, it should be applied to master branch. Frankly I haven't noticed that the fix is for |
|
Heh, well, I'm not using edge rails, so I wanted to fix stable. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow railtie and compressor to honor config settings for sass.style and assets.css_compressor with default values if not otherwise set. This allows assets.css_compressor = :yui to actually work!
The rails guide on the asset pipeline indicates that we should set config.assets.css_compressor = :yui to use the yui compressor, but it doesn't actually work. The sass-rails gem currently hijacks the config setting without regard to previous settings.
Setting ||= :compressed is pointless if the style was initialized to :expanded at the beginning of the rail ties file. So it had to be moved to the else clause of the setup_compression initializer.
Added an initializer to CssCompressor to allow for any compression style to be passed in, and then passing in from the railtie. It might be good to do the same for the other options in the compressor. The initialize method is already heading in this direction. This makes it easier to configure, and easier to test.
Added another test fixture app, with different config settings set in different environments. Calling runcmd with different environments then allows for different config paths to be run.