More flakes and prevent deadlocked actions from consuming GH quota #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-schlickmann
force-pushed
the
flaky-processes-lifecycle-test-3
branch
from
0e1e330 to
4a6034f
Compare
rosa
approved these changes
Nov 11, 2025
Member
rosa
left a comment
rosa
left a comment
There was a problem hiding this comment.
Brilliant! And great catch on the timeout for GitHub actions 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #602
Flake: processes_lifecycle_test.rb
Instructions to validate the fix locally: #678
Summary
This PR mainly increases timeout gaps between a few assertions and uses helper methods like
process_existsandwait_for_jobs_to_finish_forto fully eliminate flakiness fromprocesses_lifecycle_test.rb.This is probably the 3rd or 4th attempt 😆, but I’m confident it's the last one!
It also adds
timeout-minutes: 15to prevent deadlocked actions from consuming GitHub Actions quota.See: https://github.com/rails/solid_queue/actions/runs/18691886640/job/53299407575 (6h duration!)