Clarify nodeModules loader in CHANGELOG.md #1893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New `nodeModules` loader significantly change behavior. It's specified in **Breaking changes** section but description is quite small. As example, @javan have issue with `nodeModules` loader (rails#1892). Also, in my build it breaks `mapbox-gl` package (mapbox/mapbox-gl-js#3422). This PR adds more details to `CHANGELOG.md` about `nodeModules` loader and receipt to keep previous behavior.
|
Ouch, @javan issue has other reasons :) So, I believe adding proposed description about |
|
@gauravtiwari @javan Please consider taking another look at this one. #1949 |
|
Feel free to open a new PR please :) |
|
@gauravtiwari |
|
@gauravtiwari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
nodeModulesloader significantly change behavior.It's specified in Breaking changes section but description is quite small.
As example, @javan have issue with
nodeModulesloader (#1892). Also, in my build it breaksmapbox-glpackage (mapbox/mapbox-gl-js#3422).This PR adds more details to
CHANGELOG.mdaboutnodeModulesloader and receipt to keep previous behavior.