Skip to content

[5.x] Yarn v3 for stable webpacker 5.x gem #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 17, 2021
Merged

[5.x] Yarn v3 for stable webpacker 5.x gem #3098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5672b93
Yarn v3 for stable webpacker 5.x
pedrofurtado Jul 26, 2021
d4ef57d
Update Gemfile-rails-edge
pedrofurtado Jul 26, 2021
ea131c9
Update Gemfile-rails-edge
pedrofurtado Jul 27, 2021
736cf20
Update ruby.yml
pedrofurtado Jul 27, 2021
9801d4c
Update helper_test.rb
pedrofurtado Jul 27, 2021
81dc763
Update helper_test.rb
pedrofurtado Jul 27, 2021
d6d82aa
Update helper_test.rb
pedrofurtado Jul 27, 2021
29d26e6
Update check_yarn.rake
pedrofurtado Jul 27, 2021
565ccc2
Update ruby.yml
pedrofurtado Aug 11, 2021
de55be5
Update Gemfile-rails-edge
pedrofurtado Aug 11, 2021
3608ede
Update helper_test.rb
pedrofurtado Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tasks/webpacker/check_yarn.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace :webpacker do
pkg_path = Pathname.new("#{__dir__}/../../../package.json").realpath
yarn_range = JSON.parse(pkg_path.read)["engines"]["yarn"]
is_valid = SemanticRange.satisfies?(yarn_version, yarn_range) rescue false
is_unsupported = SemanticRange.satisfies?(yarn_version, ">=3.0.0") rescue false
is_unsupported = SemanticRange.satisfies?(yarn_version, ">=4.0.0") rescue false

unless is_valid
$stderr.puts "Webpacker requires Yarn \"#{yarn_range}\" and you are using #{yarn_version}"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
],
"engines": {
"node": ">=10.17.0",
"yarn": ">=1 <3"
"yarn": ">=1 <4"
},
"dependencies": {
"@babel/core": "^7.14.3",
Expand Down